Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dynamic headers for otel-dc-llm #68

Merged
merged 4 commits into from
Nov 2, 2024
Merged

Use dynamic headers for otel-dc-llm #68

merged 4 commits into from
Nov 2, 2024

Conversation

jinsongo
Copy link
Collaborator

@jinsongo jinsongo commented Nov 1, 2024

LLM Otel DC can obtain x-instana-key and x-instana-host from the request sent by traceloop-sdk, so it's not required to explicitly set OTEL_EXPORTER_OTLP_HEADERS anymore.

@jinsongo jinsongo requested a review from gyliu513 November 1, 2024 22:19
@jinsongo jinsongo changed the title Use dynamic headers for llm if no OTEL_EXPORTER_OTLP_HEADERS Use dynamic headers for otel-dc-llm Nov 1, 2024
@gyliu513
Copy link
Member

gyliu513 commented Nov 2, 2024

@jinsongo one comment here: if two PRs have dependency, after the first PR created, please cut a new branch based on existing branch and create a new PR, this will generate a dependency PR.

@jinsongo jinsongo merged commit 2568a1a into main Nov 2, 2024
@jinsongo jinsongo deleted the dynamic-headers branch November 2, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants